Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log that we're skipping rows every so often #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

log that we're skipping rows every so often #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tap_zendesk/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,13 +301,18 @@ def sync(self, state):
bookmark = self.get_bookmark(state)

satisfaction_ratings = self.client.satisfaction_ratings()
skipped_count = 0
for satisfaction_rating in satisfaction_ratings:
if utils.strptime_with_tz(satisfaction_rating.updated_at) >= bookmark:
# NB: We don't trust that the records come back ordered by
# updated_at (we've observed out-of-order records),
# so we can't save state until we've seen all records
self.update_bookmark(state, satisfaction_rating.updated_at)
yield (self.stream, satisfaction_rating)
else:
skipped_count += 1
if skipped_count % 10000 == 0:
LOGGER.info("Skipped 10,000 rows as they occur before bookmark: %s", bookmark)

class Groups(Stream):
name = "groups"
Expand Down