New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDL-26578 Fix custom field date time schema #151

Open

bryantgray wants to merge 2 commits into TDL-24687/enhance-tap-performance from TDL-26578/fix-custom-field-date-time-schema

Contributor

bryantgray commented Nov 5, 2024

Description of change

Changes custom date types to use the valid json schema format date-time instead of the invalid datetime.

Manual QA steps

Verified schema produced by discovery has date-time format for custom firlds

Risks

Changing the json schema formatdatetime to date-time may cause these fields to be treated differently downstream because date-time is a valid format in the json schema spec.

Rollback steps

revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

this PR has been written with the help of GitHub Copilot or another generative AI tool

bryantgray added 2 commits

November 5, 2024 20:16


          Change datetime to date-time for schema of custom date fields

015d9f4


          bump version to v3.0.0, update changelog

5a9210a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet