Update CUSTOM_TYPES to include lookup field #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added lookup custom field type with type integer.
|
Additional resources about zendesk lookups |
dan-ladd
approved these changes
Jun 20, 2023
|
Thanks @lukas-gust, we started recently running into this issue too and your PR looks good to me. Hoping someone can review and merge? @JYOTHINARAYANSETTY , you've been on a tear recently with tap-zendesk. Thank you! Would you be able to look at this small PR? Thanks! |
cngpowered
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR adds the lookup custom type to the CUSTOM_TYPES lookup. Lookups are references to other zendesk resources so their values are integers.
https://support.zendesk.com/hc/en-us/articles/4552827736218-Announcing-lookup-relationship-fields-for-Support
https://support.zendesk.com/hc/en-us/articles/4591924111770#topic_wny_w3k_5tb
Relates to #117
https://jira.talendforge.org/browse/TDL-22790
Manual QA steps
Risks
Rollback steps