Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parameter name for including inactive owners #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andykram
Copy link

Description of change

Fixes naming of API parameter to include deactivated owners from includeInactives to includeInactive (remove the trailing s). #92 was the changeset which originally attempted to add the functionality.

The naming of the parameter is documented in the Hubspot API Docs for v2 Owners.

Manual QA steps

  1. Enabled include_inactives and ran the tap, pulling no inactive accounts.
  2. Made the change in this PR and re-ran the tap, pulling all inactive accounts.

Risks

  • Users who thought they were pulling inactive users will have a surprise in store.

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

Hi @andykram, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @andykram!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants