feat: use the official Google API python library #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @paulRbr, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @paulRbr! Thank you for signing the Singer Contribution License Agreement. |
paulRbr
force-pushed
the
use-google-api-client
branch
2 times, most recently
from
0e1c1cb
to
a836362
Compare
These changes will make use of the official `google-api-python-client` library instead of relying on manual HTTP requests. Therer are two main advantages of these changes: - the Tap doesn't need to worry about the Google API interaction details as its hidden away by the Google official lib. - We can use the authentication helpers from the lib to ease the credentials management for the user. In that way the current PR implements two auth mean: installed OAuth client authentication or Service Accounts authentication. The only downside of this change is that it breaks the current `config.json` parameters for existing users.
|
Hi @kspeer825, hi @jeffhuth-bytecode what do you think of this change? Thanks! |
paulRbr
force-pushed
the
use-google-api-client
branch
from
a836362
to
4bf1940
Compare
Hello, we have a backlog ticket to review this change. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
These changes will make use of the official
google-api-python-clientlibrary instead of relying on manual HTTP requests.
There are two main advantages of these changes:
details as its hidden away by the Google official lib.
credentials management for the user. In that way the current PR
implements two auth mean:
Manual QA steps taken
--discovermode--catalogargument)Risks
The only downside of this change is that it breaks the current
config.jsonparameters for existing users.