Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set on_giveup in backoff to reraise Exception #42

Closed
wants to merge 1 commit into from
Closed

Set on_giveup in backoff to reraise Exception #42

wants to merge 1 commit into from

Conversation

GuillaumeDesforges
Copy link

Description of change

Same as singer-io/tap-facebook#117

Calling CLI tap-google-analytics returns exit code 0 even when it fails

Risks

  • programs that once relied on tap-google-analytics not to return exit code 1 can now fail.

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant