Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set on_giveup in backoff to reraise Exception #117

Closed
wants to merge 1 commit into from
Closed

Set on_giveup in backoff to reraise Exception #117

wants to merge 1 commit into from

Conversation

GuillaumeDesforges
Copy link

Description of change

Fixes #116

Risks

  • programs that once relied on tap-facebook not to return exit code 1 can now fail.

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

Hi @GuillaumeDesforges, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @GuillaumeDesforges!

Thank you for signing the Singer Contribution License Agreement.

@luandy64
Copy link
Contributor

luandy64 commented Feb 5, 2021

@GuillaumeDesforges Do you have logs showing the tap errors and exits 0? I'm surprised that's happening

@luandy64
Copy link
Contributor

@GuillaumeDesforges I'm closing this PR for now. Please open it again if you want to talk about it

@luandy64 luandy64 closed this Feb 10, 2021
@luandy64
Copy link
Contributor

Right, but the tap should still get the error raised by backoff, catch it here and then exit non-zero. I'm assuming you are seeing different behavior though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return exit code 0 on failure
3 participants