avoid Cancel/Reset/Delay operation after Close

singchia · Nov 8, 2023 · b0e8064 · b0e8064
1 parent ed69786
commit b0e8064
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/tick.go b/tick.go
@@ -47,6 +47,12 @@ type tick struct {
 
 // TODO revision
 func (t *tick) Reset(data interface{}) error {
+	t.tw.mtx.RLock()
+	defer t.tw.mtx.RUnlock()
+	if t.tw.twStatus != twStatusStarted {
+		return ErrTimerNotStarted
+	}
+
 	ch := make(chan *operationRet)
 	t.tw.operations <- &operation{
 		tick:     t,
@@ -66,6 +72,9 @@ func (t *tick) Reset(data interface{}) error {
 func (t *tick) Cancel() error {
 	t.tw.mtx.RLock()
 	defer t.tw.mtx.RUnlock()
+	if t.tw.twStatus != twStatusStarted {
+		return ErrTimerNotStarted
+	}
 
 	ch := make(chan *operationRet)
 	t.tw.operations <- &operation{
@@ -85,6 +94,11 @@ func (t *tick) Delay(d time.Duration) error {
 	if t.cyclically {
 		return ErrDelayOnCyclically
 	}
+	t.tw.mtx.RLock()
+	defer t.tw.mtx.RUnlock()
+	if t.tw.twStatus != twStatusStarted {
+		return ErrTimerNotStarted
+	}
 	ch := make(chan *operationRet)
 	t.tw.operations <- &operation{
 		tick:     t,