Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphQL: changed size attribute of File to Float #1299

Closed
wants to merge 1 commit into from

Conversation

sirtoobii
Copy link

@sirtoobii sirtoobii commented Oct 7, 2022

Resolves #889

This bug needs to be addressed since its effect on the file admin is potentially devastating: In our case we migrated an SS3 installation to SS4 and they had files larger than the 2147483647 32-bit integer size which basically rendered the whole file admin unusable.

As long there is no support for 64-bit integers, this could be feasible workaround.

An other approach would be to define a custom scalar type - is this supported by silverstripe's graphQL implementation?

@GuySartorelli
Copy link
Member

Hi there,
Thank you for submitting this pull request.

I don't think this is a good approach to resolving the issue - the type should not be a float, it should be an int. An appropriate solution would be to implement a larger int type (which you have also referred to in silverstripe/silverstripe-graphql#501).

I'm going to close this PR but if you want to give a go at implementing a proper 64bit int type I'd be happy to look at a PR which solves it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL query breaks on large files (32-bit int issue)
2 participants