Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory usage calculation logic to bench_build_tree #118

Merged
merged 16 commits into from
Nov 24, 2023

Conversation

matthewpratt13
Copy link
Collaborator

(branched off matt/simple-benchmarks)

@Stentonian Stentonian changed the base branch from main to matt/simple-benchmarks November 24, 2023 08:49
Copy link

@Stentonian Stentonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good. Did you test the jemalloc library on some structure that you know the size of?

I changed the base branch of the PR to make it easier to review, but you can change it back if you want.

Cargo.toml Outdated
Comment on lines 67 to 69
# memory usage
jemalloc-ctl = "0.5.4"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need this as a dev dependency, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I moved it

@matthewpratt13 matthewpratt13 marked this pull request as ready for review November 24, 2023 17:51
@matthewpratt13 matthewpratt13 merged commit 7e3d1c6 into matt/simple-benchmarks Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants