Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab policy error fix #1605

Merged
merged 12 commits into from
Jun 19, 2024
Merged

GitLab policy error fix #1605

merged 12 commits into from
Jun 19, 2024

Conversation

SuperDelphi
Copy link
Contributor

This pull request allows the GitLab hosting connector to handle a case where the publication fails because the GitLab user is recent. The connector will check if it's plugged to the official GitLab instance, and if so, it will display a clear message inside the publication dialog, with a clickable link.

On a side note, the loading bar ( element) inside the publication dialog has been slightly improved.

demo

Copy link
Member

@lexoyo lexoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, but olivier was working on the same piece of code, you will have to rebase on main (i already have merged his work)

Thank you for this important contribution (both bug fix and ui) !

package.json Outdated Show resolved Hide resolved
src/ts/plugins/server/GitlabHostingConnector.ts Outdated Show resolved Hide resolved
SuperDelphi and others added 8 commits June 19, 2024 11:34
* gitlab hosting connector with good current job id return

* gitlab hosting connector with good current job id return 2

* gitlab hosting connector with good current job id return v3

* with setTimout problem corrected

* with setTimout problem corrected 2

* with setTimout problem corrected 3

* with setTimout problem corrected 3

* with setTimout problem corrected 3

* with setTimout problem corrected 4

* with setTimout problem corrected 4

* with setTimout problem corrected 5

* with setTimout problem corrected 5

* with setTimout problem corrected 6

* with timer in variables

---------

Co-authored-by: Ubuntu <[email protected]>
…verify their GitLab account when needed + Loading bar visual improvement
Copy link
Contributor Author

@SuperDelphi SuperDelphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged the changes of Olivier and addressed the problems you pointed out!

@SuperDelphi SuperDelphi requested a review from lexoyo June 19, 2024 10:17
@lexoyo lexoyo merged commit 44f2023 into silexlabs:dev Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants