Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct log index in inclusion proof #1599

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Conversation

cdris
Copy link

@cdris cdris commented Jul 26, 2023

Summary

Swaps to using the inclusion proof log index instead of the entry log index in the inclusion proof struct.

@cdris cdris requested a review from a team as a code owner July 26, 2023 17:21
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1599 (bcea467) into main (2bd83da) will decrease coverage by 19.23%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1599       +/-   ##
===========================================
- Coverage   67.00%   47.78%   -19.23%     
===========================================
  Files          83       75        -8     
  Lines        8389     7775      -614     
===========================================
- Hits         5621     3715     -1906     
- Misses       2092     3700     +1608     
+ Partials      676      360      -316     
Flag Coverage Δ
e2etests ?
unittests 47.78% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/tle/tle.go 96.29% <100.00%> (ø)

... and 55 files with indirect coverage changes

Signed-off-by: Ceridwen Coghlan <[email protected]>
pkg/tle/tle.go Outdated Show resolved Hide resolved
Signed-off-by: Ceridwen Coghlan <[email protected]>
@cdris cdris requested a review from bobcallaway July 26, 2023 19:21
@bobcallaway bobcallaway merged commit 87dd2cd into sigstore:main Jul 26, 2023
14 checks passed
@cdris cdris deleted the patch-1 branch July 26, 2023 19:52
@github-actions github-actions bot added this to the v1.2.2 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants