Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict match of errors in backfill sync #6520

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented Oct 21, 2024

Issue Addressed

Same spirit as

Handling errors in sync with a fallback match is not great. In the case of backfill sync it's very easy to fix! =D

(tangent) Noting a chat with @pawanjay176 in #6321 BeaconChainError actually includes errors that are not internal. In this case it was some of the variants of HistoricalBlockError.. I'll review BeaconChainError to double check there's no other hidden scorable variants.

Proposed Changes

Turns out that its processing returns almost only variants of HistoricalBlockError, so I changed import_historical_block_batch to return HistoricalBlockError instead of BeaconChainError.

All logic is the same, just made the match on network beacon processor cleaner a bit cleaner.

@dapplion dapplion added ready-for-review The code is ready for review syncing labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review syncing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant