Trigger sampling after gossip block is execution valid #6492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
force-pushed
the
gossip-trigger-sampling
branch
from
8e45552
to
9633c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolve a PeerDAS todo
Proposed Changes
Wait for a gossip block to be execution valid before triggering sampling. Otherwise, the block might have invalid transactions and trigger us to ask peers for data that does not exist. However, a proposer could still include valid blob transactions and withhold data, causing the same situation. Since gossip blocks are proposer signature valid, we have some DOS protection.
I'm 50/50 on this change being necessary, thoughts?