This repository has been archived by the owner on Apr 21, 2021. It is now read-only.
Assume lowercase file name for PR template file #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also includes support for the PULL_REQUEST_TEMPLATE subdirectory supported by Github. See https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes support for the PULL_REQUEST_TEMPLATE subdirectory
supported by Github. See
https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository.
This is my first time contributing to any sort of elisp project, let me know what I can do to make this process better/easier!
The main thing I was trying to fix here is that the current upcased
PULL_REQUEST_TEMPLATEdoesn't match the downcasedpull_request_template.mdused by my organization. I dug into Github's docs and it looks like the template can be in a few different places that were not yet supported by magit-gh-pulls.This PR changes the case on the expected file to the lowercase that Github suggests, and adds in the other places where this file could be found. It does not add support for multiple templates.