refactor: avoid duplicate sort calls #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chintankavathia
force-pushed
the
refactor/sort-2
branch
from
992450a
to
2dde4fe
Compare
chintankavathia
force-pushed
the
refactor/sort-2
branch
2 times, most recently
from
bf4f231
to
0ed6bba
Compare
chintankavathia
force-pushed
the
refactor/sort-2
branch
2 times, most recently
from
52b2626
to
f968632
Compare
chintankavathia
force-pushed
the
refactor/sort-2
branch
from
c66e93a
to
84dd633
Compare
chintankavathia
force-pushed
the
refactor/sort-2
branch
from
84dd633
to
4a9478b
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Currently on initialization internal sort is called multiple times (>4) which is not needed.
Also sort is called twice when ghost loading is enabled with virtual infinite scroll.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
sortInternalRowsis called only once avoiding redundant calls.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: