refactor: switch to control flow syntax #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-rabbit
requested changes
Oct 1, 2024
projects/ngx-datatable/src/lib/components/body/body-cell.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/footer/footer.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/header/header-cell.component.ts
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/header/header.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/header/header.component.ts
Outdated
Show resolved
Hide resolved
timowolf
requested changes
Oct 1, 2024
projects/ngx-datatable/src/lib/components/body/body-cell.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/body/body-cell.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-datatable/src/lib/components/header/header-cell.component.ts
Show resolved
Hide resolved
chintankavathia
force-pushed
the
refactor/use-control-flow
branch
2 times, most recently
from
3d73a82
to
524af2b
Compare
chintankavathia
force-pushed
the
refactor/use-control-flow
branch
from
524af2b
to
f734c54
Compare
chintankavathia
force-pushed
the
refactor/use-control-flow
branch
from
f734c54
to
6beadd3
Compare
timowolf
reviewed
Oct 2, 2024
| } | ||
| } | ||
|
|
||
| <ng-template #bodyRow> |
There was a problem hiding this comment.
If we need this template, should we than reuse it in line 117. Feels strange to have the same element here twice.
timowolf
approved these changes
Oct 2, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: