Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(coverage): disable Codecov patch #2674

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented May 14, 2024

This PR doesn't change the previously defined coverage percentages.

Codecov initiates two tests (project and patch). The patch analyzes the percentage file by file, without considering the overall project context, which can cause CI failures even when the project coverage is in line with the established.

In order to maintain better productivity, this PR quiets the patch CI.

CI examples:

Screenshot 2024-05-14 at 07 55 48 Screenshot 2024-05-14 at 07 54 55

Example of PRs that would be less productive even with proper overall coverage:

@wellwelwel wellwelwel marked this pull request as ready for review May 14, 2024 10:57
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (81736a5) to head (5b08e35).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2674   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          71       71           
  Lines       15727    15727           
  Branches     1339     1340    +1     
=======================================
  Hits        14206    14206           
  Misses       1521     1521           
Flag Coverage Δ
compression-0 90.32% <ø> (ø)
compression-1 90.32% <ø> (ø)
tls-0 89.85% <ø> (ø)
tls-1 90.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sidorares sidorares merged commit b924c5a into sidorares:master Jun 13, 2024
64 checks passed
@wellwelwel wellwelwel deleted the codecov-patch branch June 13, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants