Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add manifest properties to talosctl executable #9429

Open
brantgurga opened this issue Oct 2, 2024 · 0 comments
Open

add manifest properties to talosctl executable #9429

brantgurga opened this issue Oct 2, 2024 · 0 comments

Comments

@brantgurga
Copy link

Feature Request

Add manifest properties to the talosctl executable.

Description

Right now the talosctl executable for Windows does not have properties filled in. The main impact of those properties is informative. If somebody were to produce a Windows Installer-based installation, I know the file version property matters.

From the research I've done, Go does not natively support manifest entries, but there are tools like go-winres (https://github.com/tc-hib/go-winres) that appear to be able to do it without too much trouble.
Current properties on Windows for 1.8.0. Ideally things like File version would be filled in with 1.8.0.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant