Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support running go-winres on Windows binaries for embedding manifest properties #450

Open
brantgurga opened this issue Oct 12, 2024 · 2 comments

Comments

@brantgurga
Copy link

brantgurga commented Oct 12, 2024

I got issues open with omni and talos to add manifest properties to the Windows executables. The primary place to change in my proof of concept is in the Dockerfile. Since that Dockerfile is generated by kres, the kres executable needs updated with the relevant lines. I already got a branch with a kres update that it did indeed output the desired lines, but I gotta refine it more.
See also the issue for omnictl: siderolabs/omni#666
See also the issue for talosctl: siderolabs/talos#9429
See also https://github.com/siderolabs/omni/pull/667/commits for the omnictl POC which manually edits Dockerfile so far
Draft change so far for kres for this: #451

@DmitriyMV
Copy link
Member

Can you link all of this in one place please?

@brantgurga
Copy link
Author

@DmitriyMV updated the description with links to other related pieces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants