This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Update ecdsa_secp256k1.nr with a test
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test with a basic check for `eq` method.
|
The points are represented as jacobian coordinates and not usual projective coordinates. You can check that it works if you change it to this let g_projective_z_doubled = Point{
x: curve.gen.x.mul(two).mul(two),
y: curve.gen.y.mul(two).mul(two).mul(two),
z: two,
}; |
|
Thank you for the link and sorry for bothering! Should I just close the PR or is it better to add a corrected version of the test that you posted so that future reader won't fall into the same misunderstanding? |
|
We can add a test. Can you fix it? |
|
yeah, of course |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
I feel like this test should pass, but it fails! Could you, pls, indicate the cause of failure? Maybe I just got something wrong. =(