fix: add more wrapping_muls

shuklaayush · Dec 2, 2023 · 9a87629 · 9a87629
1 parent 4bec17d
commit 9a87629
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/crates/curves/src/ecdsa_secp256k1/fp.nr b/crates/curves/src/ecdsa_secp256k1/fp.nr
@@ -1,3 +1,4 @@
+use dep::std;
 use dep::std::println;
 
 use dep::biguint::{BigUint56, utils};
@@ -175,7 +176,7 @@ impl PrimeField {
 
  let mut carry2 = 0;
  for i in 0..NUM_LIMBS {
- let k = tmp[i] * PrimeField::P_INV();
+ let k = std::wrapping_mul(tmp[i], PrimeField::P_INV());
  let mut carry = 0;
  for j in 0..NUM_LIMBS {
  let (prod, c) = utils::mac(tmp[i + j], k, modulus.limbs[j], carry);

diff --git a/crates/curves/src/ecdsa_secp256k1/fq.nr b/crates/curves/src/ecdsa_secp256k1/fq.nr
@@ -1,3 +1,4 @@
+use dep::std;
 use dep::std::println;
 
 use dep::biguint::{BigUint56, utils};
@@ -175,7 +176,7 @@ impl PrimeField {
 
  let mut carry2 = 0;
  for i in 0..NUM_LIMBS {
- let k = tmp[i] * PrimeField::P_INV();
+ let k = std::wrapping_mul(tmp[i], PrimeField::P_INV());
  let mut carry = 0;
  for j in 0..NUM_LIMBS {
  let (prod, c) = utils::mac(tmp[i + j], k, modulus.limbs[j], carry);

diff --git a/crates/curves/src/ed25519/fp.nr b/crates/curves/src/ed25519/fp.nr
@@ -1,3 +1,4 @@
+use dep::std;
 use dep::std::println;
 
 use dep::biguint::{BigUint56, utils};
@@ -175,7 +176,7 @@ impl PrimeField {
 
  let mut carry2 = 0;
  for i in 0..NUM_LIMBS {
- let k = tmp[i] * PrimeField::P_INV();
+ let k = std::wrapping_mul(tmp[i], PrimeField::P_INV());
  let mut carry = 0;
  for j in 0..NUM_LIMBS {
  let (prod, c) = utils::mac(tmp[i + j], k, modulus.limbs[j], carry);

diff --git a/crates/curves/src/ed25519/fq.nr b/crates/curves/src/ed25519/fq.nr
@@ -1,3 +1,4 @@
+use dep::std;
 use dep::std::println;
 
 use dep::biguint::{BigUint56, utils};
@@ -175,7 +176,7 @@ impl PrimeField {
 
  let mut carry2 = 0;
  for i in 0..NUM_LIMBS {
- let k = tmp[i] * PrimeField::P_INV();
+ let k = std::wrapping_mul(tmp[i], PrimeField::P_INV());
  let mut carry = 0;
  for j in 0..NUM_LIMBS {
  let (prod, c) = utils::mac(tmp[i + j], k, modulus.limbs[j], carry);