Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Fixed bug where cached settings aren't getting properly applied in Nuke10.5v6 #27

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Bug: Fixed bug where cached settings aren't getting properly applied in Nuke10.5v6 #27

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
906471e
added ability to set tank_channel and use_node_name in environment file
Sep 1, 2017
4edda18
fix for exposed write node parameters not being preserved #105729
Sep 15, 2017
33eb44c
Merge branch 'shotgun'
Oct 3, 2017
2491b37
merge from shotgun latest
Oct 3, 2017
2dcc329
#105729: Imported TankWrite nodes are losing settings
Oct 4, 2017
368a934
merge with shotgun/v1.3.1
Jan 26, 2018
a6fc56a
Bug: Fixed bug where cached settings aren't getting properly applied …
Jan 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions python/tk_nuke_writenode/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ def __set_profile(self, node, profile_name, reset_all_settings=False):
# update both the list and the cached value for profile name:
self.__update_knob_value(node, "profile_name", profile_name)
self.__update_knob_value(node, "tk_profile_list", profile_name)

# set the format
self.__populate_format_settings(
node,
Expand Down Expand Up @@ -1263,7 +1263,6 @@ def __populate_format_settings(
# promoted write node knobs. This will allow us to make sure
# that those knobs are set to the correct value, regardless
# of what the profile settings above have done.
filtered_settings = []

# Example data after splitting:
#
Expand All @@ -1284,12 +1283,8 @@ def __populate_format_settings(
self._app.log_debug(
"Found promoted write node knob setting: %s" % setting
)
filtered_settings.append(setting)

self._app.log_debug(
"Promoted write node knob settings to be applied: %s" % filtered_settings
)
write_node.readKnobs(r"\n".join(filtered_settings))
write_node.readKnobs(setting)
self.reset_render_path(node)

def __set_output(self, node, output_name):
Expand Down