Drop useless trait usage tracking

shipmonk-rnd · Sep 11, 2024 · 5f81355 · 5f81355
1 parent 59457c3
commit 5f81355
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 21 deletions.
diff --git a/src/Hierarchy/ClassHierarchy.php b/src/Hierarchy/ClassHierarchy.php
@@ -15,13 +15,6 @@ class ClassHierarchy
  */
  private array $classDescendants = [];
 
- /**
- * traitMethodKey => traitUserMethodKey[]
- *
- * @var array<string, list<MethodDefinition>>
- */
- private array $methodTraitUsages = [];
-
  /**
  * traitUserMethodKey => declaringTraitMethodKey
  *
@@ -39,7 +32,6 @@ public function registerMethodTraitUsage(
  MethodDefinition $traitUsageMethodKey
  ): void
  {
- $this->methodTraitUsages[$declaringTraitMethodKey->toString()][] = $traitUsageMethodKey;
  $this->declaringTraits[$traitUsageMethodKey->toString()] = $declaringTraitMethodKey;
  }
 
@@ -53,14 +45,6 @@ public function getClassDescendants(string $className): array
  : [];
  }
 
- /**
- * @return list<MethodDefinition>
- */
- public function getMethodTraitUsages(MethodDefinition $definition): array
- {
- return $this->methodTraitUsages[$definition->toString()] ?? [];
- }
-
  public function getDeclaringTraitMethodDefinition(MethodDefinition $definition): ?MethodDefinition
  {
  return $this->declaringTraits[$definition->toString()] ?? null;

diff --git a/src/Rule/DeadMethodRule.php b/src/Rule/DeadMethodRule.php
@@ -233,11 +233,7 @@ private function getMethodsToMarkAsUsed(Call $call): array
  $traitMethodDefinition = $this->classHierarchy->getDeclaringTraitMethodDefinition($methodDefinition);
 
  if ($traitMethodDefinition !== null) {
- $result = array_merge(
- $result,
- [$traitMethodDefinition],
- $this->classHierarchy->getMethodTraitUsages($traitMethodDefinition),
- );
+ $result[] = $traitMethodDefinition;
  }
  }