Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
I added a Dockerfile to run the application without to have to setup a webserver.
I noticed some hot spots :
/var/log/lastlog
)rtt
anymore butround-trip
)Also to get the port scan function to work, user need to tells docker to bind the ports inside the container.
I also need some feedback also to document how to run the image, will you upload the image to the Docker Hub ? (I can help you to set up simple CI) Or the user should build itself ?
Personally, I think th efirst option is better but it's up to you (: