-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use glow instead of sparkle #248
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagudev
force-pushed
the
bye-sparkle
branch
from
September 25, 2024 13:46
e036280
to
ebfbde1
Compare
sagudev
commented
Oct 9, 2024
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
3 tasks
mrobinson
approved these changes
Oct 16, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: sagudev <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Samson <[email protected]>
Signed-off-by: sagudev <[email protected]>
3 tasks
Signed-off-by: sagudev <[email protected]>
per servo/servo#33538 (comment) we will use unreleased surfman version for now can you merge this @mrobinson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sparkle is servo owned (but mostly unmaintained) gl create that we would like to archive and replace with glow, that is actively maintained and used by wgpu and wider rust community.
Part of servo/servo#33539