Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when creating WARP device on Windows #300

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Fix error when creating WARP device on Windows #300

merged 3 commits into from
Jul 26, 2024

Conversation

crbrz
Copy link
Contributor

@crbrz crbrz commented Jul 25, 2024

D3D11CreateDevice doesn't need an adapter when driver type is D3D_DRIVER_TYPE_WARP.

Fixes the error reported in servo/servo#26431 and enables running multiple WPT tests in parallel on Windows.

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! Thanks for fixing this.

@jdm jdm enabled auto-merge July 25, 2024 21:05
auto-merge was automatically disabled July 26, 2024 11:29

Head branch was pushed to by a user without write access

@jdm jdm enabled auto-merge July 26, 2024 12:25
@jdm jdm added this pull request to the merge queue Jul 26, 2024
Merged via the queue into servo:main with commit e077b41 Jul 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants