chore: Fix Windows workflow #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
approved these changes
Jul 15, 2024
|
For some reason the Windows build isn't terminating with these changes. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
I ended up having to downgrade LLVM here instead of upgrading, otherwise this would stall on the mozangle build. In general, the mozangle build is not great. It takes a very long time and this issue with LLVM is a bad sign. I hope to find some time to debug it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows workflow currently breaks due to chocolatey return failure when updating llvm to a specific version 17.0.6 but llvm 18.1.6 is already installed. (see https://github.com/servo/surfman/actions/runs/9890578015/job/27369196314#step:4:19)
We should maybe just skip upgrading (downgrading?) it for now.