Load libEGL.so.1 and fallback to unversioned soname #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the GStreamer update in Servo, the nightly binaries
have been failing to launch on linux distros unless
`libegl1-mesa-dev` or the equivalent package is installed
in the runtime environment.
The binaries were loading before the GStreamer update was
because the binary had a compile-time link to libEGL.so.1
due to gstreamer-sys crate. Because of this compile-time
link, the dlsym calls are able to succesfully load the
functions pointers even though the previous dlopen('libEGL.so')
call returned a NULL handle indicating failure.
This patch makes surfman load `libEGL.so.1` first and
fallback to `libEGL.so`. If neither are available, then
the initialization panics, unlike the previous behavior
where we silently succeed if the binary has a link to
the libEGL shared object with the symbols for functions
that are used at the runtime.
Fixes #276.
Signed-off-by: Mukilan Thiyagarajan <[email protected]>
mukilan
commented
Feb 26, 2024
| @@ -2,7 +2,7 @@ | |||
| name = "surfman" | |||
| license = "MIT OR Apache-2.0 OR MPL-2.0" | |||
| edition = "2018" | |||
| version = "0.9.0" | |||
| version = "0.9.1" | |||
There was a problem hiding this comment.
I am not sure if we need to bump the minor version here instead, as this patch could break consumers that are working due to the presence of a link to libEGL.so.1 in the binary, similar to servo.
mrobinson
approved these changes
Feb 26, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the GStreamer update in Servo, the nightly binaries have been failing to launch on linux distros unless
libegl1-mesa-devor the equivalent package is installed in the runtime environment.The binaries were loading before the GStreamer update was because the binary had a compile-time link to libEGL.so.1 due to gstreamer-sys crate. Because of this compile-time link, the dlsym calls are able to succesfully load the functions pointers even though the previous dlopen('libEGL.so') call returned a NULL handle indicating failure.
This patch makes surfman load
libEGL.so.1first and fallback tolibEGL.so. If neither are available, then the initialization panics, unlike the previous behavior where we silently succeed if the binary has a link to the libEGL shared object with the symbols for functions that are used at the runtime.Fixes #276.