Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added BigInt64 and BigUint64 Typed Array Support #416

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added BigInt64 and BigUint64 Typed Array Support #416

wants to merge 4 commits into from

Conversation

Redfire75369
Copy link
Contributor

No description provided.

sagudev
sagudev requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@sagudev sagudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add them to this test: https://github.com/servo/mozjs/blob/master/mozjs/tests/typedarray.rs

@Redfire75369
Copy link
Contributor Author

The current version of that test already does not test for all the different variants of TypedArrays. For example, none of the Int*Array and Float*Array are tested. As such, if tests are added for Big{Int,Uint}64Array, they should probably be added for all of them.

@Redfire75369 Redfire75369 force-pushed the typed-array/bigint branch 2 times, most recently from ada7c01 to 9af269c Compare December 8, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagudev sagudev sagudev requested changes

@jdm jdm jdm approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Redfire75369 @jdm @sagudev