Implement Add/Sub of Translation* for Point*
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like servo#506, these exist for the vector types. There doesn't seem to be any reason there shouldn't also work for translation types. The existing `translate` methods could be used for subtraction with `inv`, but that requires a complicated bound involving `Inv` and `Add` instead of a `Sub` bound.
nical
requested changes
Sep 28, 2023
| @@ -220,6 +220,15 @@ impl<T: Copy, Src, Dst> Translation2D<T, Src, Dst> { | |||
| point2(p.x + self.x, p.y + self.y) | |||
| } | |||
|
|
|||
| /// Translate a point by inverse and cast its unit. | |||
| #[inline] | |||
| pub(crate) fn transform_point_inv(&self, p: Point2D<T, Dst>) -> Point2D<T::Output, Src> | |||
There was a problem hiding this comment.
Let's not add _inv methods like this. You could relax the requirements on inverse or simply do the math manually in sub.
There was a problem hiding this comment.
These functions are pub(crate) since I wasn't sure they made sense in the public API or what to name them. Having them alongside the transformations in the opposite direction make it easier to see that they're correct, but the body of the function could definitely be moved directly into the Sub implementation.
There was a problem hiding this comment.
but the body of the function could definitely be moved directly into the Sub implementation.
This would be my preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #506, these exist for the vector types. There doesn't seem to be any reason there shouldn't also work for translation types.
The existing
translatemethods could be used for subtraction withinv, but that requires a complicated bound involvingInvandAddinstead of aSubbound.