Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix bidirectional association examples in v7 upgrade guide #565

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

medgardo
Copy link

Fixed bidirectional examples that were inconsistent.

  • The model Country and Countries was used. I updated all of the models in the example to use singular names.
  • Updated association aliases to be plural names citizen -> citizens as recommended for many-to-many associations
  • Fixed an error associating User to User (User.belongsToMany(User, { foreignKey: 'user_id' });) instead of to Country as further explained in the example

Thanks for the work on v7, it's looking great. I'd be happy to make changes if I misunderstood the intent of the examples here.

@medgardo medgardo requested a review from a team as a code owner April 11, 2024 20:16
@medgardo medgardo requested review from ephys and WikiRik April 11, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants