-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TS Config to support new decorators model definition #267
Conversation
Node 14 tests failed for syntax error (makes sense because Not sure if the other failures are related to my change; if someone wants to take a look and let me know, happy to update my PR. 😊 |
SQLite on Node 16 fails due to a typo, the following line should be using sequelize-sscce/.github/workflows/ci.yml Line 26 in a8ce25f
I fixed that in #261 but I forgot to look into the failing tests on there so we didn't merge that yet |
I've updated #261 and the CI is passing there. Can you base your branch on that PR and see if the CI passes still with your updates? |
@ephys did you close this on purpose? Or did this get auto-closed because you merged my PR? |
It was closed by the merge of your PR as the target branch was deleted. This PR would need to target main but it's not letting me change it anymore :/ |
Ah yes, that's what I thought. The mobile app you mentioned that you closed as completed. @johneatmon can you change the target branch to main and reopen this PR? |
@WikiRik tbh I'm not sure how to do it with this existing pull, do I have to open a new PR? |
@johneatmon not sure if you can just update the target branch and reopen. If not, you might need to open a new PR with the same changes. |
Based on this issue and this issue.
Update
tsconfig.json
:experimentalDecorators
@sequelize/core/decorators-legacy
declarations properlyUpdate
sscce-sequelize-7.ts
: