Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing deep eval #126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

testing deep eval #126

wants to merge 2 commits into from

Conversation

fabiocat93
Copy link
Collaborator

@fabiocat93 fabiocat93 commented Jul 31, 2024

Integrating @Mazenh2003's efforts (https://github.com/Mazenh2003/senselab/tree/deepeval) by solving some GitHub issues

@fabiocat93 fabiocat93 added the enhancement New feature or request label Jul 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.58%. Comparing base (1739d07) to head (626000e).
Report is 134 commits behind head on main.

Files with missing lines Patch % Lines
...elab/text/tasks/evaluate_conversation/deep_eval.py 85.71% 2 Missing ⚠️
...nselab/text/tasks/evaluate_conversation/metrics.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   59.01%   59.58%   +0.57%     
==========================================
  Files          80       84       +4     
  Lines        2830     2878      +48     
==========================================
+ Hits         1670     1715      +45     
- Misses       1160     1163       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocat93
Copy link
Collaborator Author

@batwood-1 can you take care of this from now on? with lower priority. we can discuss an action plan with some timeline during our next meeting

@batwood-1
Copy link
Collaborator

batwood-1 commented Aug 10, 2024 via email

@fabiocat93
Copy link
Collaborator Author

@batwood-1 any progress update on this? i would like to incorporate some of your PRs. can you please work on them during the next days/week and let me know when you think they are ready for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants