-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the BIDS-like saving to align with template directory #77
Conversation
ate function
Need to move all questionnaires in beh to phenotype. We don't have any behavioral experiments in the dataset. Therefore, we should not have a beh dir. |
f9800d6
to
78abe11
Compare
There should be no beh directory.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add
senselab>=0.12.0
to the requirements - the library doesn't work with earlier versions - Are you sure we want to package the audio data in src? it makes the pip package much bigger.
- Reformatting code & making changes makes it very hard to review changes. in the future, if you plan on bulk reformatting, best practice is to only reformat and do it in its own PR. Then afterward you can make your code changes.
Still in the middle of doing my testing with the latest data dump, but I think it's worth approving this and if I come up with any further improvements I can make a new PR.
Hi @alistairewj, thank you for reviewing! I didn't realize that about reformatting code and making changes in the same PR. In the future, will do my best to separate them🌱 To-dos:
|
|
This pull request updates the BIDS-like structure of the output directory to more closely follow BIDS. It also adds tests and optimizes performance. Some of the changes included in this PR:
Adds descriptions for each field to help users of the dataset understand it better.
Adds an
n_cores
parameter that determines the number of processes to use when extracting features. When using Pydra, this is also the number of separate model instances that will be created.Adds tests for the conversion code.
Adds transcriptions to the features saved with the option to use different Whisper model sizes.
Adds a
with_sensitive
parameter that determines whether to include raw audio files and transcriptions in the output.Adds a template BIDS-like directory structure.
Configure to automatically update CHANGES.md
Remove references to summer school
Ensure all these are constructed or copied to the bids-like dataset saving directory with correct names: