-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alistair/resource fixes #59
Conversation
d817bc0
to
6ff1f82
Compare
@ibevers i fixed a few bugs and made sure the tests were passing having |
@alistairewj Ah, yes, I will avoid having |
Well that effectively boils down to putting TODOs in the code, and while I don't have unilateral rules, in my opinion would be better to file those TODOs away in an issue tracker, especially if they're not really attached to existing code. |
Ah, I see that makes sense |
Shall I merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why precancerousLesions.json is deleted here, but I trust that you have a good reason
Yep! I deleted |
Noticed that the snakeCase is not respected in a few files. Not sure how this snuck through as I thought I fixed it all! Added a test to check for it.