Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return correct response if user was not updated #820

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Return correct response if user was not updated #820

merged 2 commits into from
Sep 28, 2023

Conversation

mpfeil
Copy link
Member

@mpfeil mpfeil commented Sep 28, 2023 •
edited
Loading

Description

The API returned a wrong response when updating a user with no changed values.

Closes #778

How Has This Been Tested?

One test case was added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has been linted using yarn run lint.
  • My code does not break the tests (yarn run test)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@mpfeil mpfeil merged commit 8e01cc1 into master Sep 28, 2023
5 checks passed
@mpfeil mpfeil deleted the fix/update-user branch September 28, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Wrong return type updateUser
1 participant
@mpfeil