Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.2.45 #158

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Rc 1.2.45 #158

merged 6 commits into from
Sep 2, 2024

Conversation

semuadmin
Copy link
Contributor

pyubx2 Pull Request Template

FIXES:

  1. Fix SEC-SIGLOG payload definition - thanks to @Niederb for contribution.
  2. Cater for alternate (v1, v2) versions of SEC-SIG message.

Fixes #156

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

If you're adding new UBX message definitions for Generation 9+ devices, please check for any corresponding configuration database updates (ubxtypes_configdb.py).

  • testSEC added to test_stream.py

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the bug Something isn't working label Sep 2, 2024
@semuadmin semuadmin added this to the RC 1.2.45 milestone Sep 2, 2024
@semuadmin semuadmin self-assigned this Sep 2, 2024
@semuadmin semuadmin requested a review from a team September 2, 2024 14:01
@semuadmin semuadmin added the enhancement New feature or request label Sep 2, 2024
@semuadmin semuadmin merged commit 41bcb1e into master Sep 2, 2024
@semuadmin semuadmin deleted the RC-1.2.45 branch September 2, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure of SIC-SEG changed in firmware 1.50
3 participants