Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT DEPLOY TO PROD - SHOULD ONLY GO TO STAGE] added in uuid into send function #2508

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jpang007
Copy link
Contributor

This change adds a UUID into the filename prefix if it is not configured, this is to be used to Staging test to validate if we can init a unique batch ID per sync.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.97%. Comparing base (1f43695) to head (3cd8d64).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...stination-actions/src/destinations/s3/functions.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2508      +/-   ##
==========================================
- Coverage   78.45%   77.97%   -0.48%     
==========================================
  Files        1044      991      -53     
  Lines       19945    17386    -2559     
  Branches     4003     3272     -731     
==========================================
- Hits        15647    13557    -2090     
+ Misses       3204     2741     -463     
+ Partials     1094     1088       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joe-ayoub-segment
Copy link
Contributor

Will deploy Tuesday .

hi @jpang007 is this PR intended to be used in Production by customers? If so, are you sure you want to prefix file names with these random characters?

@joe-ayoub-segment joe-ayoub-segment changed the title added in uuid into send function [DO NOT DEPLOY TO PROD - SHOULD ONLY GO TO STAGE] added in uuid into send function Oct 17, 2024
@jpang007 jpang007 changed the base branch from main to staging October 17, 2024 14:58
@jpang007 jpang007 requested a review from a team as a code owner October 17, 2024 14:58
@joe-ayoub-segment
Copy link
Contributor

Discussed with Jeremy. This change should only go to Staging, not Production.

@nick-Ag nick-Ag changed the base branch from staging to main October 17, 2024 16:35
@nick-Ag nick-Ag dismissed joe-ayoub-segment’s stale review October 17, 2024 16:35

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants