Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rajul/dv360 add to list device and contact info actions #2389

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

rvadera12
Copy link
Contributor

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

Copy link
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Display and Video 360 (Actions), Settings:
  • Destination: Display and Video 360 (Actions), Action:addToAudience, Fields:enable_batching,external_audience_id
  • Destination: Display and Video 360 (Actions), Action:removeFromAudience, Fields:enable_batching,external_audience_id
  • Destination: First Party Dv360, Action Field(s):enable_batching,external_audience_id
  • Destination: First Party Dv360, Action Field(s):enable_batching,external_audience_id

Add these new fields as optional instead and assume default values in perform or performBatch block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants