-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mentee and mentor card #170 #195
base: development
Are you sure you want to change the base?
Conversation
Co-authored-by: Anjula Shanaka <[email protected]>
@AnsarMahir there are conflictings right? Please resolve |
@AnsarMahir If you're using SVGs, please move them to the assets/svg folder. You can refer to how other SVGs are handled in the codebase for consistency. |
@AnsarMahir Can you add screenshot of some example ? |
@anjula-sack did the requested changes |
? Math.max(0, mentor.application.noOfMentees - approvedMenteesCount) | ||
: 0; | ||
|
||
const totalApplications = mentor?.mentees?.length ?? 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Total application count is also there in the mentor application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue is that , I tried already to simplify the logic as below
const appliedMenteesCount = mentor?.application?.appliedMenteesCount ?? 0;
const availableMenteeSlots = mentor?.application?.availableMenteeSlots ?? 0;
but it pop up an error,
"Property 'appliedMenteesCount' does not exist on type '{ firstName: string; lastName: string; email: string; contactNo: string; country: string; position: string; expertise: string; bio: string; isPastMentor: boolean; reasonToMentor: string; profilePic: string; ... 10 more ...; canCommit?: boolean | undefined; }'."
Tried to fix that error by adding
appliedMenteesCount?: number;
availableMenteeSlots?: number;
to the mentor interface, but did not work out. :(. That's why just left it as it is
Purpose
The purpose of this PR is to fix #170
Goals
Approach
Changes cannot be done directly to the components inside the Mentee card as these components are being used in different places across the site. The hardcoded values had to changed as they do not support dynamic transitions.
Screenshots
Checklist
Related PRs
Test environment
Learning