Fix "fsockopen(): Unable to connect to hostname:0" warning #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 10.5 #5783 +/- ##
=========================================
Coverage 90.18% 90.18%
Complexity 6434 6434
=========================================
Files 679 679
Lines 19531 19531
=========================================
Hits 17614 17614
Misses 1917 1917 ☔ View full report in Codecov by Sentry. |
This is similar to #5775. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another try at fixing #5779 (comment)
after looking a bit into it, it seems that phpunit will only fail a test when a warning is triggered from the test itself, but not the dataprovider.. intentional?