Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrays writing with PyTelTools and other improvements #8

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

lucduron
Copy link
Contributor

I am not able to run tests and dataset.equals does not seem to work on my environment (it raises a numpy.exceptions.AxisError).

But what has been tested so far:

  • test_open_dataset: OK
  • test_to_selafin: OK (same binary input/output file)
  • test_to_slice: OK only for time selection

@lucduron lucduron changed the title Fix arrays writing with PyTelTools and other improvments Fix arrays writing with PyTelTools and other improvements Feb 28, 2024
@tomsail
Copy link
Contributor

tomsail commented Feb 28, 2024

It works great thanks @lucduron (I also tested on different files).

@tomsail
Copy link
Contributor

tomsail commented Feb 28, 2024

There is still work to do on the dask/lazy indexing part though..
But I'll merge your changes already

@tomsail tomsail merged commit 4d64d83 into seareport:pyteltools Feb 28, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants