Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug for 3D data inversion #44

Merged
merged 3 commits into from
Oct 16, 2024
Merged

fix: fix bug for 3D data inversion #44

merged 3 commits into from
Oct 16, 2024

Conversation

tomsail
Copy link
Contributor

@tomsail tomsail commented Jul 28, 2024

This PR is to fix issue #43

I had to add the black tools for formatting / linting.

I'll comment below for the on the important changes.

@tomsail
Copy link
Contributor Author

tomsail commented Jul 28, 2024

The fix I provided should work for reading the data.

I just had to reshape for the:

However, since we reshape when read the data, we'd need to reshape when exporting the data too..
And I'm not sure I did my job well there (in selafin.write)

All the tests pass but one:
the comparison between the original Selafin and the one we wrote

@tomsail
Copy link
Contributor Author

tomsail commented Oct 15, 2024

I think I have cracked it

@tomsail tomsail merged commit 6abc326 into main Oct 16, 2024
4 checks passed
@tomsail tomsail deleted the fix-3D branch October 16, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant