Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github action workflow #79

Open
wants to merge 3 commits into
base: full-template
Choose a base branch
from

Conversation

NereusWB922
Copy link

@NereusWB922 NereusWB922 commented Feb 19, 2024

Fixes #66

Bumps version:

  • actions/checkout: master -> v4
  • gradle/wrapper-validation-action: v1 -> v2
  • actions/setup-java: v1 -> v4

Changes made:

  • Include setup-gradle action (for optimal execution, refer to gradle official)
  • Refactor IO redirection test workflow to reduce code duplication

@NereusWB922 NereusWB922 changed the base branch from master to full-template February 19, 2024 14:26
@damithc
Copy link
Collaborator

damithc commented Feb 27, 2024

@NereusWB922 Thanks for this PR. Is this an urgent change or can we delay it till next semester? This branch will be put into use very soon (when CS2113 tP starts, so we need to decide now)

@NereusWB922
Copy link
Author

@NereusWB922 Thanks for this PR. Is this an urgent change or can we delay it till next semester? This branch will be put into use very soon (when CS2113 tP starts, so we need to decide now)

I don't think it's urgent since the current version isn't causing any issues. We can delay it until next semester without any problems.

@damithc
Copy link
Collaborator

damithc commented Mar 1, 2024

@se-edu/tech-team-level1 For your review ...

@damithc
Copy link
Collaborator

damithc commented Jul 31, 2024

@NereusWB922 Looks like this PR got messed up after the target branch was rebased. Perhaps close this PR and PR again?

@NereusWB922 NereusWB922 force-pushed the 66-update-github-actions-workflow branch from e3fb8a7 to 31aff38 Compare August 3, 2024 06:07
@NereusWB922
Copy link
Author

@damithc Hi Prof, just rebased this branch onto the updated target branch.


- name: Merge to master
run: git checkout --progress --force ${{ github.sha }}
uses: actions/checkout@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NereusWB922 does the behavior remains the same here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants