-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AddressBook: remove unused containsTag()
AddressBook#containsTag() checks if a given Tag is in the master list of Tags. However this method is not used anywhere as there are no commands that support it, and is not part of any learning objectives. While it is used in two tests for AddressBook#addPerson(), AddressBook#containsTag(Tag):boolean is used infrequently enough to justify superseding it with AddressBook#getAllTags():UniqueTagList and UniqueTagList#contains(Tag). Let's remove AddressBook#containsTag() as unused code contributes to maintenance and comprehension overheads.
- Loading branch information
1 parent
4beca9c
commit b81b6c8
Showing
2 changed files
with
5 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters