-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
750: Teach ad-hoc hooks line parsing #757
base: main
Are you sure you want to change the base?
750: Teach ad-hoc hooks line parsing #757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for opening this pull request, @guillaume-d. Very excited to move this forward.
Left a few comments to clarify how we could potentially make this experience a seamless one without having to introduce the concept of an "ad hoc" hook to the configuration format. Curious to get your perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sincere apologies for the very slow response, @guillaume-d. Let me know your thoughts!
No problem, was started to worry something bad may have happened. |
1438fa3
to
34bf2c8
Compare
f5f0d60
to
72ed54f
Compare
72ed54f
to
3dc1d14
Compare
Hi. I think all comments have finally been adressed now. I am afraid I will not have much more time to do another review round (except maybe if feedback is very minor and comes fast, before I get sidetracked by other things). If nothing comes I will just use my fork of overcommit going forward, and use #758 and future uses of this feature from there. |
Include some (partly regression) tests and a small doc.