Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup-relayer): empty tx hash check #1549

Merged

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Oct 23, 2024

Purpose or design rationale of this PR

apply this fix: scroll-tech/go-ethereum#1080

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

Summary by CodeRabbit

  • New Features

    • Updated version number to v4.4.69, enhancing version tracking.
  • Bug Fixes

    • Updated dependencies for improved stability and performance:
      • github.com/scroll-tech/go-ethereum to a newer commit.
      • github.com/VictoriaMetrics/fastcache to v1.12.2.

@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Oct 23, 2024
Copy link

coderabbitai bot commented Oct 23, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve an update to the version number in the common/version/version.go file, changing it from "v4.4.68" to "v4.4.69". Additionally, the go.mod file for the scroll-tech/rollup module has been modified to update the versions of two dependencies: github.com/scroll-tech/go-ethereum and github.com/VictoriaMetrics/fastcache. These updates reflect a new version for the module and a minor version increment for the cache dependency, while maintaining the existing Go version.

Changes

File Change Summary
common/version/version.go Updated tag variable from "v4.4.68" to "v4.4.69"; other code remains unchanged.
rollup/go.mod Updated dependency versions: github.com/scroll-tech/go-ethereum from v1.10.14-0.20241011150208-4742882675d8 to v1.10.14-0.20241023093931-91c2f9c27f4d; github.com/VictoriaMetrics/fastcache from v1.12.1 to v1.12.2.

Poem

In the meadow, hopping high,
Version numbers reach the sky.
From v4.4.68 to v4.4.69,
Dependencies updated, all align.
With each change, we dance and play,
Celebrating code in a joyful way! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@0xmountaintop 0xmountaintop merged commit cc2441d into develop Oct 23, 2024
@0xmountaintop 0xmountaintop deleted the fix-rollup-relayer-empty-l2-block-root-hash-check branch October 23, 2024 09:52
@colinlyguo colinlyguo changed the title fix(rollup-relayer): empty l2 block root hash check fix(rollup-relayer): empty tx hash check Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants