Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup-relayer): add sync height and throughput metrics #1520

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Sep 18, 2024

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 98.18182% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.81%. Comparing base (736d850) to head (21d5f91).

Files with missing lines Patch % Lines
rollup/internal/controller/watcher/l2_watcher.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1520      +/-   ##
===========================================
+ Coverage    51.61%   51.81%   +0.19%     
===========================================
  Files          155      155              
  Lines        12780    12835      +55     
===========================================
+ Hits          6597     6651      +54     
- Misses        5609     5610       +1     
  Partials       574      574              
Flag Coverage Δ
rollup 55.92% <98.18%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

georgehao
georgehao previously approved these changes Sep 19, 2024
@colinlyguo colinlyguo merged commit 404a625 into develop Sep 19, 2024
5 checks passed
@colinlyguo colinlyguo deleted the add-sync-height-and-throughput-metrics branch September 19, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants