Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l2-watcher): add nil row consumption block metric #1518

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Sep 10, 2024

Purpose or design rationale of this PR

This PR adds a metric to track the number of times that l2 watcher fetches a block with nil row consumption:
When it's added, there are two cases:
(i) this field is temporarily missed in the internal node, and it will be recovered shortly after async ccc fills it.
(ii) a bug case: either the signer or internal node generates a block without row consumption.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.61%. Comparing base (246bf38) to head (949487a).

Files with missing lines Patch % Lines
rollup/internal/controller/watcher/l2_watcher.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1518      +/-   ##
===========================================
+ Coverage    51.60%   51.61%   +0.01%     
===========================================
  Files          155      155              
  Lines        12775    12780       +5     
===========================================
+ Hits          6593     6597       +4     
- Misses        5608     5609       +1     
  Partials       574      574              
Flag Coverage Δ
rollup 55.40% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo merged commit 736d850 into develop Sep 18, 2024
5 checks passed
@colinlyguo colinlyguo deleted the add-nil-row-consumption-metric branch September 18, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants